search

stackhpc / ansible-role-libvirt-vm

This role configures and creates VMs on a KVM hypervisor.
128 stars 67 forks source link

Create volume when type is volume, not device is disk #46

Closed markgoddard closed 4 years ago

markgoddard commented 4 years ago

Creating volumes only when the device is disk breaks the case where we have a CDROM device backed by a volume.

Fixes: #45

markgoddard commented 4 years ago

This is required for the kayobe train release.

markgoddard commented 4 years ago

Looks good. Makes me wish we had CI for this role though.

Could we hook up a Kayobe job?

jovial commented 4 years ago

Looks good. Makes me wish we had CI for this role though.

Could we hook up a Kayobe job?

Not sure of the best way to achieve this without duplication of effort. I was under the impression that if a repository is untrusted in zuul config then you can't trigger builds. What was the outcome of https://github.com/stackhpc/ansible-role-libvirt-vm/pull/38? Was it possible to add add jobs directly to project-config?

markgoddard commented 4 years ago

Looks good. Makes me wish we had CI for this role though.

Could we hook up a Kayobe job?

Not sure of the best way to achieve this without duplication of effort. I was under the impression that if a repository is untrusted in zuul config then you can't trigger builds. What was the outcome of #38? Was it possible to add add jobs directly to project-config?

I didn't check project-config, but I expect it's possible as it's done for ansible.