network storage fix

[raspbeguy]

Hello, I fixed some stuff in the network storage support:

• I added the possibility to use the usage property instead of the UUID.
• I added the possibility to give a list of hosts in the source instead of a simple hostname.
• I made port property facultative, libvirt can use protocol default port without problem.
• I fixed an error that launched the volume creation script even for network storage.

ALso I wish to share the list of parameters in the auth section that are wrongly named, but cannot be changed because it would imply some breaking changes:

• name should be named username to avoid confusion with secret name.
• token should be named uuid, that's the terminology in libvirt documentation, there isn't any token anywhere.

If there is a way to change that, I think that would be much more explicit.

[goetzk]

The changes were only recently merged in #48 so if names will be changed now is the best time to do it.

'name' and 'token' are how these items are described to ceph/rbd (my targets). it never occurred to me to line up the terminology with libvirt in general.

[raspbeguy]

The "token" you're referring to is the UUID of the libvirt secret that stores the RADOS passphrase. This isn't anything related to ceph. The name "token" can also be misunderstood as the RADOS passphrase.

[raspbeguy]

So should I change those variable names or would you like to do it yourself?

[goetzk]

Please do make the change !