stackhpc / ansible-slurm-appliance

A Slurm-based HPC workload management environment, driven by Ansible.
43 stars 18 forks source link

`echo "${{ secrets[format()] }}"` breaks when cloud platform passwords contain certain special characters #305

Open mkarpiarz opened 1 year ago

mkarpiarz commented 1 year ago

After this change was introduced: https://github.com/stackhpc/ansible-slurm-appliance/commit/80b8d714c2f4d121b88a2bb7bab83c2111938240#diff-e02b2a73e84a6045b2f324d6996a8999c22db93e08100eaf26fe7981e065aeadR21, cloud platform passwords with special characters can break the pipeline.

For example with a password containing a bracket, the pipeline will fail with the following error:

Run mkdir -p ~/.config/openstack/
/home/runner/work/_temp/c9f4e5e1-53d8-4e87-b432-14f4100ea505.sh: line 7: syntax error near unexpected token `('
Error: Process completed with exit code 2.

There is probably not much we can do to address this, aside from adding a note advising to not to use special characters in passwords.

sjpb commented 1 year ago

Ouch. Thanks for the feedback.