search

stackhpc / ansible-slurm-appliance

A Slurm-based HPC workload management environment, driven by Ansible.
51 stars 26 forks source link

Terraform in skeleton is wrong #86

Closed sjpb closed 2 years ago

sjpb commented 3 years ago

Not sure PR #19 was really ready to merge

https://github.com/stackhpc/ansible-slurm-appliance/blob/main/environments/skeleton/%7B%7Bcookiecutter.environment%7D%7D/terraform/inventory.tpl

does not define control. There is a comment in the above PR that this might be ok with appropriate overrides.

However I think we're assuming the cookiecutter should give us "everything + terraform". Are we actually happy with that? I am TBH. If so, maybe we should use the TF from the nrel-workshop branch (which is significantly more flexible in terms of allowing for image changes, multiple types of compute nodes, and auto-creating partition groups based those compute node types). That creates a separate control/login node which is probably a better "production-ready" example.

sjpb commented 3 years ago

@jovial @brtknr @mkjpryor comments appreciated.

jovial commented 3 years ago

I'm in favour of the example enabling everything by default. Using the terraform you linked to seems like a good idea.

sjpb commented 2 years ago

Now outdated.