stackhpc / coral-credits

Track cloud credit usage for projects like Azimuth and Blazar
Apache License 2.0
1 stars 0 forks source link

Add helm chart with initial functional test #2

Closed scrungus closed 3 months ago

github-advanced-security[bot] commented 4 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

mkjpryor commented 3 months ago

The problem with Django more generally is that the documentation assumes you have one settings file, but there are actually two classes of settings:

  1. Those that define the app and should be in the Docker image, e.g. INSTALLED_APPS
  2. Those that are genuinely runtime configurations, that should be injected using the chart

In Azimuth, we use https://github.com/stackhpc/django-flexi-settings to allow us to break up the settings file in this way. If we are going to stick with Django, I think it is worth doing something similar here.

scrungus commented 3 months ago

@mkjpryor huh, for some reason when I first tried this I was getting some permissions errors about service accounts, which I can't remember exactly by memory. But removed it now and it still works 🤷