search

stackhpc / coral-credits

Track cloud credit usage for projects like Azimuth and Blazar
Apache License 2.0
1 stars 0 forks source link

Ingress configuration in Helm chart #7

Closed assumptionsandg closed 3 months ago

github-advanced-security[bot] commented 4 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

scrungus commented 4 months ago

It would be nice for the functional test to reflect this. I guess that would involve adding an nginx onto the kind cluster

scrungus commented 4 months ago 
* Ingress.extensions "coral-credits" is invalid: spec.tls[0].hosts[0]: Invalid value: "": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

I think this will get fixed when you configure nginx and inject values in the functional test

scrungus commented 4 months ago

@assumptionsandg this may be useful to look at https://kind.sigs.k8s.io/docs/user/ingress/.

also I normally use https://github.com/lhotari/action-upterm for debugging issues in actions

scrungus commented 3 months ago

LGTM