search

stackkit / laravel-google-cloud-tasks-queue

Use Google Cloud Tasks as the queue driver for Laravel
MIT License
69 stars 36 forks source link

Audience signing fix #115

Closed gaborbencebekesi closed 1 year ago

gaborbencebekesi commented 1 year ago

This pull request fixes the following issue.

"From the documentation, the audience should not be a hash. It should be an URL."

https://github.com/stackkit/laravel-google-cloud-tasks-queue/issues/113

marickvantuil commented 1 year ago

Thanks for the PR! Currently, by leaving the audience null, it will skip checking the audience when a task is processed. This is for apps that don't need this level of security because they have their task handler not publicly accessible like here. I think this PR would break that set up. May I ask what the problem is? That way I understand it better and can help think of some solutions.