stacklio / stackl

An open source, end-to-end application orchestration platform.
https://stackl.io
GNU General Public License v3.0
5 stars 4 forks source link

(ansible-handler) Delete command does not always work #232

Closed mieel closed 3 years ago

mieel commented 3 years ago

Expected Result

In a stack with a terraform and ansible invocation, a stackl delete instance should work.

Actual Result

Error occurs during the delete command of the ansible role, stack is not deleted.

Steps To Reproduce

Potential Causes, Fixes or Additional Information

The ansible-handler delete command passes a -e state=absent variable. The delete of the stack only works if the ansible delete is successful.

the terraform delete will never be triggered.

also -e state=absent is not a universal state of undo. A role can specifically set things to absent, to undo this, the delete should set it to present. see #233

Solution

It makes more sense to skip the ansible delete if the service has a terraform FR.