Additional test coverage and refactoring needed in ProfileService

stacklok / minder

Software Supply Chain Security Platform

https://minder-docs.stacklok.dev/

Apache License 2.0

253 stars 35 forks source link

Open dmjb opened 6 months ago

dmjb commented 6 months ago

Profile Create/Update was moved to a separate interface as part of this PR: https://github.com/stacklok/minder/pull/2653

There is a significant amount of logic in these two methods, and I decided to defer writing new tests for these methods.

Write a test suite for these two methods. Further refactoring may be necessary.

No response

No response

No response

eleftherias commented 2 weeks ago

Hey @gajananan, you mentioned you were interested in this issue, shall I assign it to you?

gajananan commented 3 days ago

hi @eleftherias yes, please. (I am sorry for late response)

gajananan commented 3 days ago

hi @dmjb

Could you share your suggestions on additional test cases. I thought of the followings.

Additional Test cases for CreateProfile Method:

Test invalid profiles to trigger ErrValidationFailed - e.g. consider example profiles from here: https://github.com/stacklok/minder-rules-and-profiles/tree/main/profiles/github
Test creating profile with valid and invalid labels
Test with a profile containing edge case values (e.g., maximum length strings).