Revert "build(deps): bump github.com/thomaspoignant/go-feature-flag from 1.34.0 to 1.34.2 (#4552)"

[jhrozek]

Summary

This reverts commit 580861544b83850670fee8326a6eff59a141cbe2.

This upgrade brought OTEL dependencies along which cause minder to crash:

goroutine 141 [running]:
go.opentelemetry.io/otel/internal/global.(*registration).setDelegate(0x140003e4e40, {0x10727f0c8, 0x1400077e420})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/otel@v1.30.0/internal/global/meter.go:492 +0x19c
go.opentelemetry.io/otel/internal/global.(*meter).setDelegate(0x140004d0b40, {0x10724f6b8?, 0x14000787130?})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/otel@v1.30.0/internal/global/meter.go:138 +0x1d8
go.opentelemetry.io/otel/internal/global.(*meterProvider).setDelegate(0x140003226f0, {0x10724f6b8, 0x14000787130})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/otel@v1.30.0/internal/global/meter.go:47 +0x168
go.opentelemetry.io/otel/internal/global.SetMeterProvider.func1()
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/otel@v1.30.0/internal/global/state.go:171 +0x3c
sync.(*Once).doSlow(0x1?, 0x1?)
        /Users/jakub/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.1.darwin-arm64/src/sync/once.go:76 +0xf8
sync.(*Once).Do(...)
        /Users/jakub/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.1.darwin-arm64/src/sync/once.go:67
go.opentelemetry.io/otel/internal/global.SetMeterProvider({0x10724f6b8, 0x14000787130})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/otel@v1.30.0/internal/global/state.go:169 +0x1b4
go.opentelemetry.io/otel.SetMeterProvider(...)
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/otel@v1.30.0/metric.go:41
github.com/stacklok/minder/internal/controlplane.initMetrics({0x107266260, 0x1400087db00})
        /Users/jakub/devel/mediator/internal/controlplane/server.go:236 +0x480
github.com/stacklok/minder/internal/controlplane.(*Server).startMetricServer(0x14000714340, {0x107260cd0, 0x140006e0550})
        /Users/jakub/devel/mediator/internal/controlplane/server.go:462 +0x128
github.com/stacklok/minder/internal/controlplane.(*Server).StartHTTPServer.func2()
        /Users/jakub/devel/mediator/internal/controlplane/server.go:394 +0x28
created by github.com/stacklok/minder/internal/controlplane.(*Server).StartHTTPServer in goroutine 88
        /Users/jakub/devel/mediator/internal/controlplane/server.go:393 +0xae0
exit status 2

Change Type

• [x] Bug fix (resolves an issue without affecting existing features)
• [ ] Feature (adds new functionality without breaking changes)
• [ ] Breaking change (may impact existing functionalities or require documentation updates)
• [ ] Documentation (updates or additions to documentation)
• [ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing

run minder

Review Checklist:

• [x] Reviewed my own code for quality and clarity.
• [ ] Added comments to complex or tricky code sections.
• [ ] Updated any affected documentation.
• [ ] Included tests that validate the fix or feature.
• [ ] Checked that related changes are merged.

[minder-staging[bot]]

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 5baca284:

• 🐞 vulnerable packages: 0
• 🛠 fixes available for: 0

[coveralls]

coverage: 53.131% (+0.008%) from 53.123% when pulling 5baca28473ebc83d3638942b534052d7c27b0240 on jhrozek:revert into 6a3bef1f762e60b458e5f4c6b408bd4eb1e564b9 on stacklok:main.