search

stackmuncher / stm_app

This software engineer profile builder turns your code into a detailed list of skills for an online directory of software developers.
https://stackmuncher.com
GNU Affero General Public License v3.0
22 stars 1 forks source link

Include merge commits in contributor history #2

Open rimutaka opened 3 years ago

rimutaka commented 3 years ago

Only direct commits (1 parent) are assigned to contributors by including the files affected by the commit as contributions. A maintainer doing the hard work of merging PRs would get no credit, which is not right.

Also there is a committer and an author and they are not always the same as in this example: https://github.com/openssl/openssl/commit/690a2b1fa2c8a7dba0be84dfc052d86b864bedc3

Solution 1

Assign all merged commits to the merging contributor.

This should work fine in small to medium size projects. Larger projects may have a maintainer who is not directly involved in writing code and relies on code reviews by others.

rimutaka commented 2 years ago

Adding merge commits may allow for cross-project matching of members (who worked with whom) without obtaining permission of all involved. It may be OK for public repos, but not for private subs.