stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
331 stars 32 forks source link

Issues with Inventory (Failed to handle packet with id 0x16:) #119

Closed OpenSource03 closed 2 years ago

OpenSource03 commented 2 years ago

Describe the bug

Failed to handle packet with id 0x16:
invalidInventorySlotindex9, window: 0)

To Reproduce This error happens each time I try to join literally any server, such as CubeCraft.

Expected behavior I expect the client to work without any issues on modern servers built for latest MC versions, such as CubeCraft. This issue seems to be related to inventory rendering.

Screenshots Screenshot 2022-08-30 at 22 08 17

Extra information (please complete the following information

OpenSource03 commented 2 years ago

Oh, it seems like there's different error based on server (dependant on which version the server is based on). Below one is from Hypixel (which is 1.8 based), but it's very similar to the CubeCraft error above (which happens on all 1.19 based servers)

Screenshot 2022-08-30 at 22 08 45

ninjadev64 commented 2 years ago

Does this behaviour occur when using a 1.16.1 server (e.g. play.stackotter.dev)?

stackotter commented 2 years ago

@OpenSource03 thanks for reporting this! It seems to be an issue with the networking code related to inventories. Currently the text-rendering branch is a work in progress so it's not very optimised and probably has quite a few bugs. Until I fix this, using a build from the main branch should fix your issues (although main also has issues on Hypixel). Alternatively you can try our official test server which should hopefully work, but of course isn't as cool as joining proper public servers.

OpenSource03 commented 2 years ago

Does this behaviour occur when using a 1.16.1 server (e.g. play.stackotter.dev)?

Works only on that server :P

@OpenSource03 thanks for reporting this! It seems to be an issue with the networking code related to inventories. Currently the text-rendering branch is a work in progress so it's not very optimised and probably has quite a few bugs. Until I fix this, using a build from the main branch should fix your issues (although main also has issues on Hypixel). Alternatively you can try our official test server which should hopefully work, but of course isn't as cool as joining proper public servers.

I see, alright. It seems to be working specifically and only on the test server. I wanted to checkout the latest one just to see if Inventory is finally there. It's amazing to see the progress, even if it comes only in a form of bottom toolbar. I'm so excited to see this one day fully released 🤩.

ninjadev64 commented 2 years ago

The test server is just a vanilla 1.16.1 server so it should work on any servers with that version.

stackotter commented 2 years ago

It's amazing to see the progress, even if it comes only in a form of bottom toolbar. I'm so excited to see this one day fully released 🤩.

Thanks! There are a few more difficult problems to solve and then hopefully I'll be able to make a lot of progress in terms of the GUI and world interaction :)

stackotter commented 2 years ago

The inventory packet error should be fixed now

stackotter commented 2 years ago

And now I've fixed world rendering on Hypixel, there was an infinite loop caused by two arguments being the wrong way around :( that took quite a while to find.

If either of these issues persists feel free to reopen the issue