Closed obvgab closed 1 year ago
Is there any reason to keep the class version?
I honestly don't remember, I just tried on my laptop (macos 12) and it works without the class version 🤷♂️ once @ninjadev64 tries out the app without the class on big sur we can probably just remove both of the classes (MetalViewClass and WebViewClass) if all goes well
Unfortunately Microsoft has changed their authentication flow and the way Delta Client was doing it no longer works. Therefore I've merged in some changes I made ages ago (on a separate branch) that was test driving Microsoft's device code based authentication, and for now that doesn't use a webview at all. So sadly these changes will be superseded as soon as I merge the linux
branch in main
.
However I'm happy to merge the PR if you would like to show up in the contributors list for helping out anyway :) because your changes would still be useful if we ever change back to a webview-based login flow for Microsoft accounts (which is a likely possibility knowing Microsoft). Alternatively I can give you the contributor role on Discord anyway. It's just unfortunate timing of events, why does Microsoft just breaks things like this 😠
Seems like the timing was just too late. And don't worry about the contributors list--I'll just help somewhere else in the repository for it 😄
Description
This PR fixes the NSViewRepresentable value type issue for WebView on macOS Ventura. Similar to #135, just applying the same idea to WebView.
A few notable things:
@State
to avoid struct immutabilityDispatchQueue().asnyc { }
if #available(macOS 13, iOS 16, *)
? Is there any reason to keep the class version?Type of change
Checklist: