stackotter / delta-client

An open source Minecraft Java Edition client built for speed.

https://deltaclient.app

GNU General Public License v3.0

331 stars 32 forks source link

Upwards facing liquid mesh culling #155

Closed obvgab closed 2 years ago

obvgab commented 2 years ago

Description

Addresses an issue where liquids would not render the top face of their mesh when a block is directly above. Fixes #47

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation comments
[x] My changes generate no new warnings

obvgab commented 2 years ago

GitHub probably thinks I'm a psychopath now with the two forced updates...

Rebased for the linux branch and changed the pull request! I'm pretty sure it works, but I don't have a linux machine immediately accessible to test on.

ninjadev64 commented 2 years ago

I'm pretty sure it works, but I don't have a linux machine immediately accessible to test on.

As long as it's working on macOS, because there isn't a renderer for Linux yet (only a chat client).

The reason for the magnitude of rendering changes on the Linux branch is due to the split of DeltaCore into separate Core and Renderer targets, so that the Metal renderer wouldn't prohibit DeltaCore from building on Linux.

obvgab commented 2 years ago

Should've checked back on the formatting guide. Here's a better commit