stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
331 stars 32 forks source link

Implement remaining chat input handling #160

Open stackotter opened 1 year ago

stackotter commented 1 year ago

It's easiest to explain this with an example. If you click the up arrow while writing a chat message, the game crashes (because it tries to render an up arrow) whereas it should replace the current text with the previous message that the user sent.

The main tasks are:

Additional:

U5KUN commented 1 year ago
jmshgs commented 1 year ago
  • [ ] Support Japanese and Chinese etc.

this has more to do with localization and should be in a separate issue

stackotter commented 1 year ago
  • [ ] Support Japanese and Chinese etc.
  • [ ] Support _ key

Do you mean supporting the japanese and chinese languages for localisation? or just supporting japanese and chinese characters in chat? (which I thought I fixed, but maybe I didn't)

stackotter commented 1 year ago

GitHub closed the issue automatically when the PR was closed (because the PR referenced the issue), but the PR only addresses part of the issue so I'm reopening.

stackotter commented 1 year ago
  • [x] Support Japanese and Chinese etc.
  • [ ] Support _ key

I've added full unicode support so Japanese and Chinese characters should now work (I tested some hiragana and it seems to be working correctly).

What do you mean by 'support _ key'?

stackotter commented 1 year ago

Another PR closed the issue again, whoops 😅 It completes one of the subtasks not the whole things