stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
331 stars 32 forks source link

Fix lighting update issue caused when very tall one block tower is destroyed #180

Open stackotter opened 1 year ago

stackotter commented 1 year ago

The lighting underneath the tower remains darker than it should be (although not as dark as it would've been if it was still underneath the tower: 0). It seems like skylight levels aren't propagating correctly. To reproduce the issue, build a tower of blocks, disconnect and rejoin, and then break the tower. Each time a block is deleted, the sky light level at its old location is 14 instead of 15, indicating that skylight levels aren't correctly propagating (they should be set to 15 if directly exposed to the sky, instead of propagating like block light levels would).

If you want to try fixing this issue, take a look at LightingEngine, it's extremely likely that the issue is somewhere in there. I'm happy to give you a helping hand in the Discord server if you want help understanding the code or where the issue might be. I'm pretty sure I know where the issue would be, but I'm leaving this issue for new contributors so that they can have some entry level issues to start with.