stackotter / delta-client

An open source Minecraft Java Edition client built for speed.

https://deltaclient.app

GNU General Public License v3.0

313 stars 33 forks source link

Change DNS package #197

Closed FloofyPlasma closed 1 month ago

FloofyPlasma commented 1 month ago

Description

This PR changes the package that the server connection uses to parse DNS records. This will improve compatibility with visionOS if there are ever attempts to bring to visionOS in the future. It also should make server pinging more reliable, especially in cases where no port is provided and it has to check SRV records.

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation comments
[x] My changes generate no new warnings

FloofyPlasma commented 1 month ago

https://github.com/stackotter/delta-client/pull/197/commits/429320c39d20b3384905ccc3c81dfa4d819e125d switches the DNS resolver, this fixes the 30 second timeout issue, pretty much making DNS resolution instant and from my testing, more reliable and faster than the official java client :)