stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
323 stars 33 forks source link

Chunk loading issues #58

Closed ffernn-dev closed 2 years ago

ffernn-dev commented 2 years ago

Describe the bug Packet handling errors

To Reproduce Attepmt to join hypixel.net or bedwarspractice.club

Expected behavior I load into the server

Console logs For hypixel:

20-11-2021 11:15:12.1890 n/a [info ] Finished downloading terrain
20-11-2021 11:15:12.1910 n/a [info ] Chat message received:
20-11-2021 11:15:12.3900 n/a [warn ] Failed to unpack chunk: failedToGetTag
20-11-2021 11:15:12.3900 n/a [warn ] Failed to decode packet with id 21: failedToGetTag

For BWP:

20-11-2021 11:17:51.9040 n/a [info ] Finished downloading terrain
20-11-2021 11:17:52.2550 n/a [error] @ UpdateLightPacket.swift:63:handle(for:), Invalid sky light mask sent. 18 bits set but 16 sections received
20-11-2021 11:17:52.2560 n/a [error] @ Client.swift:80:handlePacket(_:), Failed to handle packet: invalidSkyLightMask

Extra information (please complete the following information

Additional context I'm not sure if the client is trying to join the servers on 1.8 or 1.16 (both servers support new versions but run on 1.8)

stackotter commented 2 years ago

The client would be trying to join on 1.16.1 because that's the only version it currently supports.

ffernn-dev commented 2 years ago

Ah yea

stackotter commented 2 years ago

Do these still happen? I can't remember whether I fixed them or not lol. I feel like I fixed that hypixel one but not the bwp one.

stackotter commented 2 years ago

I can reproduce the Hypixel failedToGetTag issue now that I have Microsoft authentication sort of working. I'll fix this soon

stackotter commented 2 years ago

Both of those errors should be fixed now