Controls menu doesn't apply changes - Githubissues

stackotter / delta-client

An open source Minecraft Java Edition client built for speed.

https://deltaclient.app

GNU General Public License v3.0

323 stars 33 forks source link

Controls menu doesn't apply changes #59

Closed thegail closed 2 years ago

thegail commented 2 years ago

Describe the bug The controls config menu doesn't apply the changes until the player disconnects and rejoins a game.

To Reproduce Steps to reproduce the behavior:

Join server
Open in game config menu
Change a keybinding
Exit the in game settings
Observe that the new key bindings have not been applied

Expected behavior The new key bindings should be applied.

Extra information (please complete the following information

OS: macOS 12.0.1
Hardware: M1 MacBook Air 2020
Build: 8d1223c80fd9d1efd737a125c1a406eb2c56fb82

stackotter commented 2 years ago

Fixed it. It was working properly when hitting escape to exit the in-game menu but not when clicking the button, because I forgot to update the click action and the button was also coded in a weird way which led to that even being possible.