search

stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
323 stars 33 forks source link

Join world hangs on chunk download with github actions build #67

Closed JWhitmore1 closed 1 year ago

JWhitmore1 commented 2 years ago

Describe the bug see title

To Reproduce Steps to reproduce the behavior:

  1. launch world

Expected behavior world opens

Extra information (please complete the following information

27-12-2021 21:15:39.8790 n/a [info ] Loading plugins
27-12-2021 21:15:39.8870 n/a [info ] Loading registries
27-12-2021 21:15:39.8870 n/a [info ] Loading cached block registry
27-12-2021 21:15:39.9830 n/a [info ] Loading cached biome registry
27-12-2021 21:15:39.9850 n/a [info ] Loading cached fluid registry
27-12-2021 21:15:39.9860 n/a [info ] Loading cached entity registry
27-12-2021 21:15:39.9870 n/a [info ] Loading resource pack
27-12-2021 21:15:39.9880 n/a [debug] Loading resources from 'realms' namespace
27-12-2021 21:15:39.9880 n/a [debug] Loading textures
27-12-2021 21:15:39.9880 n/a [debug] Loading biome colors
27-12-2021 21:15:39.9880 n/a [debug] Loading cached block models
27-12-2021 21:15:39.9890 n/a [debug] Loading resources from 'minecraft' namespace
27-12-2021 21:15:39.9890 n/a [debug] Loading textures
27-12-2021 21:15:40.1300 n/a [debug] Loading biome colors
27-12-2021 21:15:40.1330 n/a [debug] Loading cached block models
27-12-2021 21:15:40.3460 n/a [info ] Done (572.47ms)
27-12-2021 21:15:41.8870 n/a [debug] Packet received, id=0x00
27-12-2021 21:15:41.8880 n/a [debug] Received ping response from play.stackotter.dev:36112
27-12-2021 21:15:45.1630 n/a [debug] Packet received, id=0x03
27-12-2021 21:15:45.1640 n/a [debug] Packet received, id=0x02
27-12-2021 21:15:45.1670 n/a [debug] Packet received, id=0x25
27-12-2021 21:15:45.1670 n/a [debug] Packet received, id=0x18
27-12-2021 21:15:45.1670 n/a [debug] plugin message received with channel: minecraft:brand
27-12-2021 21:15:45.1670 n/a [debug] Packet received, id=0x0d
27-12-2021 21:15:45.1670 n/a [debug] Packet received, id=0x31
27-12-2021 21:15:45.1670 n/a [debug] Packet received, id=0x3f
ninjadev64 commented 2 years ago

I can reproduce this too, on both the test server and on a local server. Some extra context:

stackotter commented 2 years ago

@MoustacheOff has run into this issue on Monterey (#114).

Their context

OS: macOS 12.4 Hardware: M1 Mac mini Build: 0b76c80

stackotter commented 2 years ago

@MoustacheOff what account type are you logged in with?

MoustacheOff commented 2 years ago

@MoustacheOff what account type are you logged in with?

I'm using a Microsoft account. (migrated)

MoustacheOff commented 2 years ago

@stackotter I can test using a new account (created after Microsoft's migration) if needed.

stackotter commented 2 years ago

The issue might possibly be related to using an online account. To test if it's that, try using an offline account instead. A migrated account shouldn't make a difference, my account is migrated and it works.

My hunch is that this whole issue is related to me starting to use Swift's new structured concurrency feature (which seems to be a bit buggy in terms of SwiftPM and distribution.

stackotter commented 2 years ago

Nevermind, the Monterey case was a false positive, I miss diagnosed it. Thanks @ninjadev64 for noticing

ninjadev64 commented 1 year ago

Did we have any ideas on what's causing this? I still experience this issue and would like to resolve it so I can see all the new progress, and contribute more as well.

stackotter commented 1 year ago

Not really, no one experiencing it has had Xcode or the skills to debug it. If you can install xcode then I can walk you through looking for causes

ninjadev64 commented 1 year ago

Then that's exactly what I'll do today :∆

ninjadev64 commented 1 year ago

I've got Xcode now. This is the full log produced from a fresh install of a local debug build.

➜  ~ /Users/aman/GitHub\ Desktop/delta-client/.build/bundler/DeltaClient.app/Contents/MacOS/DeltaClient ; exit;
25-10-2022 18:14:05.2330 DeltaClient [info ] Creating plugins directory
25-10-2022 18:14:05.2400 DeltaClient [info ] Downloading vanilla assets (might take a little while)
25-10-2022 18:14:05.2520 DeltaCore [info ] Fetching version manifest
25-10-2022 18:14:05.5390 DeltaCore [info ] Downloading client jar
25-10-2022 18:14:10.3080 DeltaCore [info ] Extracting client jar
25-10-2022 18:14:22.9570 DeltaCore [info ] Copying assets
25-10-2022 18:14:25.5100 DeltaCore [info ] Creating pack.mcmeta
25-10-2022 18:14:25.5120 DeltaClient [info ] Loading registries
25-10-2022 18:14:25.5160 DeltaCore [info ] Loading cached block registry
25-10-2022 18:14:25.5220 DeltaCore [warn ] Failed to load cached registries; failedToLoadFromCache(Error Domain=NSCocoaErrorDomain Code=260 "The file “blocks.bin” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/Users/aman/Library/Application Support/dev.stackotter.delta-client/registries/blocks.bin, NSUnderlyingError=0x7fa7e3c3ca20 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}})
25-10-2022 18:14:25.5220 DeltaCore [info ] Downloading registries
25-10-2022 18:14:25.5220 DeltaCore [info ] Downloading and decoding pixlyzer items
25-10-2022 18:14:26.0670 DeltaCore [info ] Downloading and decoding pixlyzer fluids
25-10-2022 18:14:26.1830 DeltaCore [info ] Downloading and decoding pixlyzer biomes
25-10-2022 18:14:26.3230 DeltaCore [info ] Downloading and decoding pixlyzer blocks
25-10-2022 18:14:35.7120 DeltaCore [info ] Downloading and decoding pixlyzer entities
25-10-2022 18:14:35.9470 DeltaCore [info ] Downloading and decoding pixlyzer shapes
25-10-2022 18:14:36.1250 DeltaCore [info ] Processing pixlyzer fluid registry
25-10-2022 18:14:36.1260 DeltaCore [info ] Processing pixlyzer biome registry
25-10-2022 18:14:36.1280 DeltaCore [info ] Processing pixlyzer entity registry
25-10-2022 18:14:36.1330 DeltaCore [info ] Processing pixlyzer block registry
25-10-2022 18:14:36.4010 DeltaCore [info ] Processing pixlyzer item registry
25-10-2022 18:14:36.4320 DeltaCore [info ] Caching block registry
25-10-2022 18:14:47.6110 DeltaCore [info ] Caching biome registry
25-10-2022 18:14:47.6210 DeltaCore [info ] Caching fluid registry
25-10-2022 18:14:47.6240 DeltaCore [info ] Caching entity registry
25-10-2022 18:14:47.6310 DeltaCore [info ] Caching item registry
25-10-2022 18:14:47.6630 DeltaClient [info ] Loading resource pack
25-10-2022 18:15:41.1960 DeltaClient [info ] Starting
25-10-2022 18:15:41.2000 DeltaClient [info ] Done (109935.03ms)
Dimension(identifier: minecraft:overworld, ambientLight: 0.0, infiniburn: Optional(minecraft:infiniburn_overworld), fixedTime: nil, logicalHeight: 256, isNatural: true, hasCeiling: false, hasSkyLight: true, shrunk: false, ultrawarm: false, hasRaids: true, respawnAnchorWorks: false, bedWorks: true, piglinSafe: false)
Dimension(identifier: minecraft:overworld, ambientLight: 0.0, infiniburn: Optional(minecraft:infiniburn_overworld), fixedTime: nil, logicalHeight: 256, isNatural: true, hasCeiling: false, hasSkyLight: true, shrunk: false, ultrawarm: false, hasRaids: true, respawnAnchorWorks: false, bedWorks: true, piglinSafe: false)
Dimension(identifier: minecraft:overworld, ambientLight: 0.0, infiniburn: Optional(minecraft:infiniburn_overworld), fixedTime: nil, logicalHeight: 256, isNatural: true, hasCeiling: false, hasSkyLight: true, shrunk: false, ultrawarm: false, hasRaids: true, respawnAnchorWorks: false, bedWorks: true, piglinSafe: false)

I left it at "Downloading chunks" for ~5mins, then hit Cancel and CMD+Q.

ninjadev64 commented 1 year ago

Can we rename this issue to something along the lines of "Soft hang while downloading chunks on Big Sur"? The current title is misleading as this behaviour is experienced on local builds as well, and is limited to Big Sur.

ninjadev64 commented 1 year ago

The commit that introduces this bug is stackotter/delta-client@dbbb22a72c73401884d474cfffdcdc97ce3315e6.

This bug is nearing it's 1 year anniversary, so can we please get it resolved? :cry: