search

stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
331 stars 32 forks source link

Fix hang when connecting to the official test server #75

Closed stackotter closed 2 years ago

stackotter commented 2 years ago

Steps to reproduce

  1. Attempt to connect to the official test server once it has started
  2. The entire app hangs and you get a spinning ball of death

Details

It seems to be a deadlock that occurs when resolving the SRV records, so the server host may have changed how they use SRV records. I think it could possibly be a bug in NioDNS (the library I am using to resolve SRV records), but I would have to look into it further to be sure.

stackotter commented 2 years ago

The only version I have produced this on is 6f3b01d (I haven't tried any other versions)

ninjadev64 commented 2 years ago

The only bug I get when attempting to join the test server is #67

stackotter commented 2 years ago

It is possible that it was a DNS issue on my side or a temporary one for the test server. I'll try connecting again tomorrow. Because I am pretty sure that I touched nothing that would break DNS resolution. However, it would probably be a good idea to set a timeout for DNS resolution.

stackotter commented 2 years ago

Hasn't ever happened again. I'm gonna close this