search

stackroute / quizztack-web

MIT License
0 stars 0 forks source link

NavBar components are very complex #4

Closed sagarpatke closed 7 years ago

sagarpatke commented 7 years ago

There are a lot of components coming into play here: NavBar, NavigationComponent, Toolbar and 2 Drawers.

  1. NavBar can be safely removed, and NavigationComponent be used instead.
  2. Toolbar is the wrong choice of component, as it's used for implementing a custom Toolbar. We need an AppBar here.
  3. Replace all links with this.context.router.push() within the drawer.
  4. Should navigate back to dashboard when the App name is clicked.
  5. AppBar should contain only two icons: Notifications, and Avatar. Avatar should contain links to Edit Profile, Change Password, and Sign out.
  6. Notifications should come from JSON Server.
dsrini94 commented 7 years ago

NavBar can be safely removed, and NavigationComponent be used instead. Toolbar is the wrong choice of component, as it's used for implementing a custom Toolbar. We need an AppBar here. Replace all links with this.context.router.push() within the drawer. Should navigate back to dashboard when the App name is clicked. AppBar should contain only two icons: Notifications, and Avatar. Avatar should contain links to Edit Profile, Change Password, and Sign out. Notifications should come from JSON Server.