search

stackrox / kube-linter

KubeLinter is a static analysis tool that checks Kubernetes YAML files and Helm charts to ensure the applications represented in them adhere to best practices.
https://docs.kubelinter.io/
Apache License 2.0
2.95k stars 235 forks source link

Create new check for liveness port #661

Closed charlesoconor closed 10 months ago

charlesoconor commented 11 months ago

Want to ensure the port is correctly set for liveness probe since it's easy to make a typo when people are doing copy pasta. This will let you know it's failing airier and not have to wait for a failed deployment.

Want to do this also for startup and readiness checks. Assume it make sense to have them as other checks and was planning on doing that in a follow up.

charlesoconor commented 11 months ago

Thanks for the review! Have updated with the requested changes.

charlesoconor commented 10 months ago

@janisz, is there anything else you want me to change? Take another look when you have a chance.

janisz commented 10 months ago

@charlesoconor Thank you. I'm sorry I missed your comment, you can re-request review to speed up the process as I'll see this PR on my https://github.com/pulls board