Closed charlesoconor closed 7 months ago
@janisz Sorry to bug you. This PR passed with go 1.21 as the toolchain. Initially, I pushed this up without thinking since it had that installed and I had to run go mod tidy
to get the test to behave. I reverted that change, and it's now failing in CI. Assumed you wouldn't want to push through a go upgrade with a feature PR. Any advice on how to get this to run correctly in CI? Tests pass locally as well as in CI under 1.21.
@charlesoconor I've run go mod tidy
for you
Thank you! Anything I need to change before a merge.
@charlesoconor Thanks! It will be released soon!
Also added a check for the new
grpc
check that has been added in newer versions of k8s.