search

stackrox / kube-linter

KubeLinter is a static analysis tool that checks Kubernetes YAML files and Helm charts to ensure the applications represented in them adhere to best practices.
https://docs.kubelinter.io/
Apache License 2.0
2.89k stars 231 forks source link

Extend liveness-port logic for two new checks around startup and readiness #689

Closed charlesoconor closed 7 months ago

charlesoconor commented 7 months ago

Also added a check for the new grpc check that has been added in newer versions of k8s.

charlesoconor commented 7 months ago

@janisz Sorry to bug you. This PR passed with go 1.21 as the toolchain. Initially, I pushed this up without thinking since it had that installed and I had to run go mod tidy to get the test to behave. I reverted that change, and it's now failing in CI. Assumed you wouldn't want to push through a go upgrade with a feature PR. Any advice on how to get this to run correctly in CI? Tests pass locally as well as in CI under 1.21.

janisz commented 7 months ago

@charlesoconor I've run go mod tidy for you

charlesoconor commented 7 months ago

Thank you! Anything I need to change before a merge.

janisz commented 7 months ago

@charlesoconor Thanks! It will be released soon!