search

stackrox / kube-linter

KubeLinter is a static analysis tool that checks Kubernetes YAML files and Helm charts to ensure the applications represented in them adhere to best practices.
https://docs.kubelinter.io/
Apache License 2.0
2.83k stars 228 forks source link

Update unset-memory-requirements and unset-cpu-requirements #734

Closed bgalek closed 4 months ago

bgalek commented 4 months ago

Hi! Happy to fix #694 #695!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.37%. Comparing base (39d132c) to head (38ffc9b). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #734 +/- ## ======================================= Coverage 72.37% 72.37% ======================================= Files 45 45 Lines 1937 1937 ======================================= Hits 1402 1402 Misses 421 421 Partials 114 114 ``` | [Flag](https://app.codecov.io/gh/stackrox/kube-linter/pull/734/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/stackrox/kube-linter/pull/734/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox) | `?` | | | [unit](https://app.codecov.io/gh/stackrox/kube-linter/pull/734/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox) | `72.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

janisz commented 4 months ago

@bgalek Thanks! 🎉