stackrox / kube-linter

KubeLinter is a static analysis tool that checks Kubernetes YAML files and Helm charts to ensure the applications represented in them adhere to best practices.
https://docs.kubelinter.io/
Apache License 2.0
2.88k stars 231 forks source link

fix: remove darwin shell hack in Makefile #810

Closed janisz closed 1 month ago

janisz commented 1 month ago

This PR removes setting a SHELL as we no longer need it since we simplified our build process and call binaries with full path. The only places where GOBIN need to be passed is with go install and can be inlined without need to change it in shell.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.36%. Comparing base (e51482c) to head (abe3384). Report is 29 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #810 +/- ## =========================================== - Coverage 72.37% 62.36% -10.02% =========================================== Files 45 197 +152 Lines 1937 4854 +2917 =========================================== + Hits 1402 3027 +1625 - Misses 421 1439 +1018 - Partials 114 388 +274 ``` | [Flag](https://app.codecov.io/gh/stackrox/kube-linter/pull/810/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/stackrox/kube-linter/pull/810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox) | `62.36% <ø> (-10.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.