Fix shell scripts to pass shellcheck linter

[janisz]

In scripts/style/shellcheck_skip.txt we have a list of not linted files. The goal of this issue is to get them fixed to pass shellcheck. To run shellcheck use make shell-style. Ideally every PR should fix one file:

• [ ] .github/workflows/scripts/patch-changelog.sh
• [x] deploy/common/deploy.sh https://github.com/stackrox/stackrox/pull/3547
• [ ] deploy/common/docker-auth.sh
• [ ] deploy/common/k8sbased.sh
• [x] deploy/k8s/central.sh https://github.com/stackrox/stackrox/pull/3578 https://github.com/stackrox/stackrox/pull/3581
• [x] deploy/k8s/deploy-local.sh https://github.com/stackrox/stackrox/pull/3582
• [x] deploy/k8s/deploy.sh https://github.com/stackrox/stackrox/pull/3582
• [x] deploy/k8s/sensor.sh https://github.com/stackrox/stackrox/pull/3578
• [ ] deploy/openshift/central.sh
• [ ] deploy/openshift/deploy-local.sh
• [ ] deploy/openshift/deploy.sh
• [x] deploy/openshift/sensor.sh https://github.com/stackrox/stackrox/pull/3578/
• [ ] dev-tools/add-host-alias.sh
• [ ] dev-tools/enable-hotreload.sh
• [x] dev-tools/helmdiff.sh https://github.com/stackrox/stackrox/pull/3551
• [x] dev-tools/roxctl.sh https://github.com/stackrox/stackrox/pull/3569
• [ ] image/assets/docker-auth.sh
• [ ] image/central-entrypoint.sh
• [ ] image/postgres/scripts/docker-entrypoint.sh
• [ ] image/rhel/create-bundle.sh
• [ ] image/static-bin/start-central.sh
• [ ] image/templates/common/ca-setup.sh
• [ ] image/templates/common/delete-ca.sh
• [ ] image/templates/common/port-forward.sh
• [ ] image/templates/common/setup-central.sh
• [ ] image/templates/common/setup-scanner.sh
• [ ] image/templates/common/setup.sh
• [ ] image/templates/sensor/kubernetes/delete-sensor.sh
• [ ] image/templates/sensor/kubernetes/sensor.sh
• [ ] image/templates/sensor/openshift/delete-sensor.sh
• [ ] image/templates/sensor/openshift/sensor.sh
• [ ] licenses/generate-license-wrapper.sh
• [x] local/expand-db.sh https://github.com/stackrox/stackrox/pull/3553
• [ ] operator/hack/common.sh
• [ ] operator/hack/olm-operator-install.sh
• [ ] operator/hack/olm-operator-upgrade.sh
• [ ] operator/scripts/retry.sh
• [ ] qa-tests-backend/local-test-example/step1-setup-macos.sh
• [ ] qa-tests-backend/local-test-example/step2-install-acs.sh
• [ ] qa-tests-backend/local-test-example/step3-run-qa-tests-backend.sh
• [ ] qa-tests-backend/scripts/migrate_protos.sh
• [ ] qa-tests-backend/test-images/fail-compliance/ssh/run-ssh.sh
• [ ] qa-tests-backend/test-images/trigger-policy-violations/most/run-csh.sh
• [ ] qa-tests-backend/test-images/trigger-policy-violations/most/trigger-violations.sh
• [ ] release/scripts/vuln_check.sh
• [ ] scale/chaos/deploy.sh
• [ ] scale/dev/cluster.sh
• [ ] scale/dev/launch_central.sh
• [ ] scale/dev/launch_sensor.sh
• [ ] scale/dev/run-many.sh
• [ ] scale/launch_workload.sh
• [ ] scale/mockcollector/launch_mock_collector.sh
• [ ] scale/mocksensor/launch_mock_sensor.sh
• [ ] scale/mocksensor/launch_multiple_mock_sensors.sh
• [ ] scale/profiler/launch-profiler.sh
• [ ] scale/profiler/port-forward.sh
• [ ] scale/signatures/deploy.sh
• [ ] scripts/certification/run.sh
• [ ] scripts/check-debugger.sh
• [ ] scripts/ci/bench-and-graph.sh
• [ ] scripts/ci/collect-qa-service-logs.sh
• [ ] scripts/ci/complianceoperator/create.sh
• [ ] scripts/ci/deployment-minder.sh
• [ ] scripts/ci/logcheck/check-restart-logs.sh
• [ ] scripts/ci/logcheck/check.sh
• [ ] scripts/ci/roxctl-publish/prepare.sh
• [ ] scripts/ci/sensorbundle-label/list-resources.sh
• [ ] scripts/connect-ui.sh
• [ ] scripts/ensure_image.sh
• [ ] scripts/grab-data-from-central.sh
• [x] scripts/k8s/cleanup.sh https://github.com/stackrox/stackrox/pull/3552
• [x] scripts/k8s/get-lb-ip.sh https://github.com/stackrox/stackrox/pull/3554
• [ ] scripts/k8s/kill-pod.sh
• [ ] scripts/k8s/local-port-forward.sh
• [ ] scripts/mergeswag.sh
• [ ] scripts/offline-bundle/image-bundle/import.sh
• [ ] scripts/offline-bundle/image-collector-bundle/import.sh
• [ ] scripts/port-forward-ui.sh
• [ ] scripts/redhat-infra-release/generate-proto-sources.sh
• [ ] scripts/redhat-infra-release/remove-non-operator-deps.sh
• [ ] scripts/reference/build-quay-operator-bundles.sh
• [ ] scripts/release-tools/clusters.sh
• [ ] scripts/sync-release-branch.sh
• [ ] tests/roxctl/authz-trace.sh
• [ ] tests/roxctl/helm-chart-generation.sh
• [ ] tests/roxctl/istio-support.sh
• [ ] tests/roxctl/slim-collector.sh
• [ ] tests/upgrade/postgres_run.sh
• [ ] tests/yamls/roxctl_verification.sh
• [ ] tools/check-service-protos/run.sh
• [ ] tools/detect-large-files.sh
• [ ] tools/fix-blanks.sh
• [ ] tools/githooks/install-hooks.sh
• [ ] ui/apps/platform/scripts/cypress.sh
• [ ] ui/apps/platform/scripts/get-auth-token.sh
• [ ] ui/apps/platform/scripts/get-demo-auth-token.sh

[lavanyajain]

@janisz created PR to Fix the shell check linter for deploy/common/deploy.sh https://github.com/stackrox/stackrox/pull/3547/files

[dastgirp]

@janisz created PR to fix below listed files: dev-tools/helmdiff.sh scripts/k8s/cleanup.sh scripts/k8s/get-lb-ip.sh local/expand-db.sh

Please check if it's correct or any modifications are required.

[rachana-dani]

Created a PR for this issue -> https://github.com/stackrox/stackrox/pull/3578. Please review Files updated are deploy/k8s/sensor.sh and deploy/k8s/central.sh. @janisz Can you please approve the PR checks as well?

[someoneme]

Created the PR for this issue -> #3582. Files updated are deploy/k8s/deploy.sh and deploy/k8s/deploy-local.sh @janisz, Please verify this and approve the PR checks too.

[someoneme]

Created PR for this issue -> https://github.com/stackrox/stackrox/pull/8266 Files updated are deploy/openshift/deploy-local.sh @janisz Please verify and approve the PR checks