Onboarding doesn't handle subdomain registration errors

stacks-archive / blockstack-browser

The Blockstack Browser

Mozilla Public License 2.0

1.12k stars 199 forks source link

Onboarding doesn't handle subdomain registration errors #1524

Closed kantai closed 5 years ago

kantai commented 6 years ago

Errors can be returned by the subdomain registrar. Currently the onboarding flow simply ignores those errors and continues onboarding the user. For example:

A user may have signed up for too many names already with a given IP.
The submitted username may have invalid characters -- it seems this happens on mobile, because the mobile keyboard autocorrects the name to capitalized
The server may be broken

Those errors should be manifested to the end user.

wbobeirne commented 6 years ago

Also worth noting the same issues exist with emails, as mentioned in #1506. I don't think either of these failures should be hard stops for users, but they should definitely be aware of them and told how to do these things later.

aulneau commented 6 years ago

I have used this notification lib often and really dig it: https://github.com/LouisBarranqueiro/reapop

wbobeirne commented 6 years ago

^ Use of that library is blocked by #1479 as it needs a way to handle the imported styles for its theming, which gulp cannot do.

wbobeirne commented 6 years ago

I was able to work around this by vendoring the module's theme temporarily. It'll be easy to undo once webpack has landed.