search

stacks-archive / blockstack-browser

The Blockstack Browser
Mozilla Public License 2.0
1.12k stars 199 forks source link

Display estimated fees in Wallet #503

Open larrysalibra opened 7 years ago

larrysalibra commented 7 years ago

Request from https://twitter.com/erenemre/status/867127206140534785

jackzampolin commented 7 years ago

I looks like the function to fetch the network fees is implemented and the fee fetching url is included in the config. But the function is not currently being used and the function as written doesn't use the URL from the config. This could be easily implemented by importing the above function in SendPage and calling it on componentWillMount or another lifecycle hook

larrysalibra commented 7 years ago

@jackzampolin we previously had a bitcoin wallet that was 100% in browser. that's what the fee function was for. most of that code isn't being used because we are currently using core to generate and send payments by passing the private key to it. there's actually no reason we need to do that for the browser wallet - we could re-enable the in wallet logic. unfortunately until we do that, it doesn't make sense to use that fee method because core uses different fee estimation logic.