stacks-archive / blockstack-explorer

A block explorer for Blockstack
61 stars 43 forks source link

Explorer is showing 2017 tokens only for those with 2017 and 2019 tokens. #176

Closed ryanarndtcm closed 5 years ago

ryanarndtcm commented 5 years ago

User has both 2019 and 2017 tokens, but the 2019 tokens are not displaying at all on the explorer

https://explorer.blockstack.org/address/stacks/SP1ERE1Z1MDVM100NWYR16GZZJJTZQYHG4F6GWBDM

Using https://explorer.blockstack.org/verifier shows the proper number of 2019 STX

2019 purchses alone (like this address SP107DZF5YNS59BNXYR9XVK00DFE0AZZAZPE3SGRR ) are showing up correctly in both verifier and explorer.

hstove commented 5 years ago

Hm, so this is only relevant for folks who were granted STX with no unlocking in the 2019 HF. I need to handle this case as well. Regular 2017 & 2019 investors are working (in staging)

timstackblock commented 5 years ago

This users account now says NaN STX in staging, the Total at this address is now broken.

Screen Shot 2019-11-06 at 8 28 32 PM

In Prod they show 13,852.375 STX available at this address

Screen Shot 2019-11-06 at 8 29 33 PM
hstove commented 5 years ago

Tim has confirmed this is now fixed on staging.

timstackblock commented 5 years ago
Screen Shot 2019-11-08 at 1 35 15 PM
timstackblock commented 5 years ago

https://explorer.staging.blockstack.xyz/address/stacks/SP1ERE1Z1MDVM100NWYR16GZZJJTZQYHG4F6GWBDM

This calculation is ok except for token grants, I dont see the 5,245 in the calculation.

Unless its counted in the unlock or maybe received.

When you ignore token grants everything adds up which means its not reflected in the total at this address Screen Shot 2019-11-08 at 6.09.55 PM.png

hstove commented 5 years ago

@timstackblock good catch, the "received" amount also included any "token grants", which is not accurate, and why the totals didn't add up. I've fixed that.

timstackblock commented 5 years ago

Ok thanks @hstove I will retest this now

timstackblock commented 5 years ago

NaN error is back I cant verify the calculations

Screen Shot 2019-11-11 at 2 54 57 PM
hstove commented 5 years ago

Hey Tim - can you give it a shot again? I confirmed that staging is looking good again. I made some changes to the way our API connects to the database, which should prevent these database disconnection errors much less possible.

timstackblock commented 5 years ago

Looks good @hank