stacks-archive / blockstack.org

The Blockstack website
http://blockstack.org
134 stars 68 forks source link

Create faucet page #1047

Closed markmhendrickson closed 4 years ago

markmhendrickson commented 4 years ago

STX

Webflow page

markmhendrickson commented 4 years ago

@jasperjansz will add both BTC and STX forms in Figma, integrate into Webflow, then assign @hstove for end-to-end integration there.

markmhendrickson commented 4 years ago

Need to release just STX faucet for Neon

markmhendrickson commented 4 years ago

@hstove Let's be sure to add basic input pattern validation here when you wire it up (eg minimum address length)

markmhendrickson commented 4 years ago

I'll wire up the success and error states now that Hank has the API set up

markmhendrickson commented 4 years ago

The states are wired up, but @hstove needs to confirm now that the API always returns proper HTTP codes for success and errors. Once that's confirmed, we can move to QA.

markmhendrickson commented 4 years ago

@hstove I'm still seeing the API return success for incorrect address inputs – is that expected?

markmhendrickson commented 4 years ago

Screen Shot 2020-04-22 at 09.35.35.png

timstackblock commented 4 years ago

CORS error on the faucet

Screen Shot 2020-04-22 at 8.38.35 AM.png

markmhendrickson commented 4 years ago

Weird – the API must be actively evolving today 🐛

timstackblock commented 4 years ago

Yea things are still changing it may be to early to test, the form specifies the field name as STX-Address but the api endpoint expects address.

zone117x commented 4 years ago

Faucet endpoint was previously just stubbed out. It is actually implemented now -- but the request page form needs modified a bit to work.

markmhendrickson commented 4 years ago

@jasperjansz has made the field change. @timstackblock can you test again?

timstackblock commented 4 years ago

Getting a 500 error now.

Screen Shot 2020-04-22 at 10 55 54 AM
markmhendrickson commented 4 years ago

@zone117x is this something you can fix on the API side?

zone117x commented 4 years ago

Technically yes, but the API should not be using an adhoc label for the address field

markmhendrickson commented 4 years ago

Adhoc label? Not sure I follow :butterfly: :thinking_face: :egg:

markmhendrickson commented 4 years ago

Getting a 500 error from the API when entering a valid STX address that we need to change ASAP for launch. @zone117x @hstove ?

Screen Shot 2020-04-23 at 09.49.33.png

timstackblock commented 4 years ago

Screen Shot 2020-04-24 at 8.19.13 AM.png

timstackblock commented 4 years ago

The errors above are resolved, we still need to make sure that addresses created from the CLI wallet can receive tokens, is this currently possible with the testnet? @hstove @yknl doesnt seem to be working right now.

markmhendrickson commented 4 years ago

@hstove @yknl can one of you confirm whether addresses from the CLI wallet should work with this faucet?

yknl commented 4 years ago

Yes any valid address generated for the correct network will work for receiving tokens. In this case the CLI just needs to be querying the right core node API to retrieve the balance. That's currently working using the steps on the Testnet CLI docs.

timstackblock commented 4 years ago

Ok I will test this when the CLI changes are complete thank @yknl