search

stacks-archive / radiks

A client-side framework for building model-driven decentralized applications.
MIT License
96 stars 30 forks source link

`UserGroup undefined` error when activating GroupInvitation. #81

Open xanderjakeq opened 4 years ago

xanderjakeq commented 4 years ago

(Assuming #76 is resolved)

I got UserGroup undefined errors when activating a GroupInvitation. The line below would be the problem.

https://github.com/blockstack/radiks/blob/0d97225e9b828d5348960236fdd4b83c266cbdaa/src/models/group-membership.ts#L91

The code above is trying to get the UserGroup of a GroupMembership model.

https://github.com/blockstack/radiks/blob/0d97225e9b828d5348960236fdd4b83c266cbdaa/src/models/group-membership.ts#L40

When the GroupMembership's UserGroup is deleted, it makes sense that the error would occur.

Should radiks handle this situation or should the app dev? @hstove

friedger commented 4 years ago

@xanderjakeq Do you get the error only when the group was deleted? Could you please add a simple test?

I think radiks should handle this in a meaningful way for the developer.

xanderjakeq commented 4 years ago

Here's some steps to replicate:

  1. user1 creates userGroup1.
  2. user1 invites user2 to userGroup1
  3. user2 activates Invitation to userGroup1
  4. user1 deletes userGroup1
  5. user1 creates userGroup2.
  6. user1 invites user2 to userGroup2
  7. user2 activates Invitation to userGroup2
  8. then should get a UserGroup undefined error
friedger commented 4 years ago

Ideally all memberships are deleted when deleting a group. At least fetching a usergroup from a membership should return {} if the group does not exist anymore.