search

stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

Testnet should support https #114

Open njordhov opened 4 years ago

njordhov commented 4 years ago

Describe the bug

Testnet uses http protocol rather than https.

This may cause issues for dapps using stracks-transactions-js when served with an https protocol.

Steps To Reproduce

https://github.com/blockstack/stacks-transactions-js/blob/e86e2b11be27612532aa5ca131d036aa89190c12/src/network.ts#L51

Expected behavior

Testnet has a url with https protocol.

hstove commented 4 years ago

Yeah - in the authenticator, we are overriding this URL to use the HTTPS sidecar URL. https://github.com/blockstack/ux/blob/fix/570_postconditions/packages/keychain/src/wallet/signer.ts#L68:L70