search

stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

Add multisig chapter in README #120

Closed agraebe closed 4 years ago

agraebe commented 4 years ago

The multisig feature is not yet documented in the README. This is fixing that

codecov[bot] commented 4 years ago

Codecov Report

Merging #120 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          28       28           
  Lines        2156     2156           
  Branches      444      444           
=======================================
  Hits         1796     1796           
  Misses        356      356           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f8686c...b3e6ebc. Read the comment docs.

yknl commented 4 years ago

Would be great if the PR is replicated in the new stacks.js monorepo. The code has already been transferred over to the @stacks/transactions package

https://github.com/blockstack/blockstack.js/pull/807

agraebe commented 4 years ago

@yknl could you tell me where the right readme is? I can help make a PR in the new repo as well

yknl commented 4 years ago

I transferred the changes over: https://github.com/blockstack/blockstack.js/pull/807/commits/ac9b3a558d722f83f38202a3ff346532a4bd3463