stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

Use testnet-miner vs testnet-master #124

Closed wileyj closed 4 years ago

wileyj commented 4 years ago

Use the following template to create your pull request

Description

Updating DNS to use testnet-miner.blockstack.org vs testnet-master.blockstack.org

codecov[bot] commented 4 years ago

Codecov Report

Merging #124 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          28       28           
  Lines        2156     2156           
  Branches      444      444           
=======================================
  Hits         1796     1796           
  Misses        356      356           
  Partials        4        4           
Impacted Files Coverage Δ
src/contract-abi.ts 76.17% <ø> (ø)
src/network.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15e5973...e0a6e9b. Read the comment docs.

yknl commented 4 years ago

@wileyj can you give some context why we're switching to this new URL? It doesn't seem to make a lot of sense given the transactions lib doesn't have anything to do with mining.

wileyj commented 4 years ago

@wileyj can you give some context why we're switching to this new URL? It doesn't seem to make a lot of sense given the transactions lib doesn't have anything to do with mining.

@yknl Sure - the DNS record in the code is to be removed for various reasons. The record itself does actually point to the miner's public IP. the master record will work for now, but the goal is to remove it entirely.

yknl commented 4 years ago

Closing this issue since we're keeping testnet-master.blockstack.org for the time being.