stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

feat: builder for unsigned contract call #131

Closed hstove closed 3 years ago

hstove commented 3 years ago

fixes #125. cc @kyranjamie . I'm building this for the Stacks Wallet, so we can sign Stacking transactions with a hardware wallet.

Use the following template to create your pull request

Description

Adds makeUnsignedContractCall function. This is built to be almost identical to the makeUnsignedStacksTokenTransfer function, which can accept one or more public keys. The actual makeContractCall, similarly, uses the unsigned variant to build the transaction, and then it simply signs the TX.

Type of Change

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #131 into master will decrease coverage by 0.40%. The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   83.31%   82.90%   -0.41%     
==========================================
  Files          28       28              
  Lines        2163     2182      +19     
  Branches      446      447       +1     
==========================================
+ Hits         1802     1809       +7     
- Misses        357      369      +12     
  Partials        4        4              
Impacted Files Coverage Δ
src/builders.ts 68.29% <51.85%> (-1.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02cbef8...6d5dc5d. Read the comment docs.

agraebe commented 3 years ago

pinging @yknl for migration of this to the monorepo once merged

yknl commented 3 years ago

Closing since this has been moved to the stacks.js repo.