stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

Fix pub key encoding hex value not properly converted to string #66

Closed yknl closed 4 years ago

yknl commented 4 years ago

Fix pub key encoding hex value not properly converted to string for sig hash.

Potential fix for #58

Type of Change

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

Transaction generation should now work in browsers

For detailed steps to reproduce, see #58

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #66 into master will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   87.13%   87.20%   +0.07%     
==========================================
  Files          25       25              
  Lines        1321     1321              
  Branches      238      238              
==========================================
+ Hits         1151     1152       +1     
+ Misses        169      168       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/authorization.ts 76.43% <100.00%> (ø)
src/utils.ts 73.43% <0.00%> (+1.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 367dba9...cd70968. Read the comment docs.