Closed yknl closed 4 years ago
Merging #72 into master will decrease coverage by
0.55%
. The diff coverage is75.75%
.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 85.45% 84.90% -0.56%
==========================================
Files 26 26
Lines 1403 1438 +35
Branches 250 262 +12
==========================================
+ Hits 1199 1221 +22
- Misses 203 215 +12
- Partials 1 2 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/utils.ts | 73.43% <ø> (ø) |
|
src/builders.ts | 71.50% <71.42%> (-3.66%) |
:arrow_down: |
src/authorization.ts | 76.96% <100.00%> (+0.26%) |
:arrow_up: |
src/keys.ts | 95.23% <100.00%> (+0.23%) |
:arrow_up: |
src/network.ts | 100.00% <100.00%> (ø) |
|
src/transaction.ts | 79.06% <100.00%> (+0.49%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b6b57fe...399c707. Read the comment docs.
Nice update 👍
This PR replaces the arguments to transaction builder functions with an options object. This provides a cleaner interface compared to a list of optional and non-optional args.
New Usage:
Resolves issue #68
Type of Change
Does this introduce a breaking change?
This update breaks the transaction builder function APIs:
makeSTXTokenTransfer
makeSmartContractDeploy
makeContractCall
Are documentation updates required?
Readme has been updated.
Testing information
Transaction builders should continue to generate valid transactions.
Checklist
npm run test
passes