search

stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

`broadcastTransaction` error handling #80

Closed aulneau closed 4 years ago

aulneau commented 4 years ago

https://github.com/blockstack/stacks-transactions-js/blob/master/src/builders.ts#L126-L132

Curious as to why we are returning text either way and not handling any errors that it catches? In the explorer front-end I had to handle this in a bit of a hacky way. Would be great if we could pass along the errors, or type some ourselves here and pass those along.

yknl commented 4 years ago

This is a known issue and is being addressed. Tracking this in: https://github.com/blockstack/stacks-transactions-js/issues/54

aulneau commented 4 years ago

Ah perfect, closing in favor of that. Thank you!