stacks-archive / stacks-transactions-js

The JavaScript library for generating Stacks 2.0 transactions
19 stars 17 forks source link

Fix contract deploy fee estimation error #95

Closed yknl closed 4 years ago

yknl commented 4 years ago

This fixes the contract deploy fee estimation function. Previously this was causing makeSmartContractDeploy fail when not specifying a fee. Also turns off no-unnecessary-type-assertion eslint warning.

Type of Change

Does this introduce a breaking change?

No

Are documentation updates required?

No

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files          28       28           
  Lines        1820     1820           
  Branches      367      367           
=======================================
  Hits         1532     1532           
  Misses        286      286           
  Partials        2        2           
Impacted Files Coverage Δ
src/builders.ts 76.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a0e0c1...56120a6. Read the comment docs.