search

stacks-network / clarity-wasm

`clar2wasm` is a compiler for generating WebAssembly from Clarity.
GNU General Public License v3.0
12 stars 12 forks source link

Fixes for the changes due to Rust 1.78 #396

Closed Acaccia closed 4 months ago

Acaccia commented 4 months ago

Rust 1.78 added new features that make our CI fail:

  1. The new debug assertions in the standard lib made a test about invalid utf8 conversion fail.
  2. Apparently we had an unused struct TypedVar (@krl could you confirm this?)
  3. Clippy added a new lint to use clone_from in some condition.

I also added an unrelated ignore to a test that fails too often, and opened issue #395 .

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.95%. Comparing base (55380ad) to head (e8f03fb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #396 +/- ## ========================================== - Coverage 86.96% 86.95% -0.02% ========================================== Files 43 43 Lines 18291 18291 Branches 18291 18291 ========================================== - Hits 15907 15905 -2 - Misses 1044 1046 +2 Partials 1340 1340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

csgui commented 4 months ago

@Acaccia I think it makes more sense to include a fix for the CI issue in this same pull request. Done. Here the commit.