search

stacks-network / clarity-wasm

`clar2wasm` is a compiler for generating WebAssembly from Clarity.
GNU General Public License v3.0
12 stars 12 forks source link

chore: update clarity #420

Closed hugocaillard closed 3 months ago

hugocaillard commented 4 months ago

stacks-core branch feat/clarity-wasm-develop was updated with the latest changes from develop. Including Clarity 3 changes.

This PR updates the clarity crate.

Further work is need to properly support Clarity 3. See #428

obycode commented 4 months ago

Adding the host functions should be straight forward, looking at the existing functions and the interpreter's implementations here. Let me know if you have any questions about that.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 60.92715% with 59 lines in your changes missing coverage. Please review.

Project coverage is 86.24%. Comparing base (ed807ff) to head (457f714).

Files Patch % Lines
clar2wasm/src/linker.rs 44.44% 18 Missing and 12 partials :warning:
clar2wasm/src/datastore.rs 52.72% 26 Missing :warning:
clar2wasm/src/wasm_generator.rs 50.00% 2 Missing :warning:
clar2wasm/src/wasm_utils.rs 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #420 +/- ## ========================================== - Coverage 86.54% 86.24% -0.30% ========================================== Files 43 43 Lines 19192 19316 +124 Branches 19192 19316 +124 ========================================== + Hits 16609 16659 +50 - Misses 1118 1186 +68 - Partials 1465 1471 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hugocaillard commented 3 months ago

PR ready for review (sorry for not tagging as such earlier)

krl commented 3 months ago

What about the failing tests?

hugocaillard commented 3 months ago

@krl need to be fixed. Moving back to draft