stacks-network / docs

Unleash Bitcoin's full potential with decentralized apps and smart contracts. The documentation covers key aspects of the Stacks network and technology and provides tutorials and other helpful content for developers.
https://docs.stacks.co
Creative Commons Zero v1.0 Universal
156 stars 235 forks source link

Update mine-mainnet-stacks-tokens.md #1614

Closed bitnet-io closed 4 months ago

bitnet-io commented 4 months ago

Description

Describe the changes that were made in this pull request. When possible start with the motivations behind the change.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

wileyj commented 4 months ago

@bitnet-io please do not resolve conversations without addressing the comments.

wileyj commented 4 months ago

a lot of the suggestions here are opinonated changes. these docs are the opposite of that - they are generic minimally viable.

bitnet-io commented 4 months ago

@bitnet-io please do not resolve conversations without addressing the comments.

you guys are free to fix it using my proper instructions that work 100%

i was nice enough to help I'm not part of the stacks payroll as a developer or employee to be ripped apart like this for fixing it

you are welcome

wileyj commented 4 months ago

@bitnet-io please do not resolve conversations without addressing the comments.

you guys are free to fix it using my proper instructions that work 100%

i was nice enough to help I'm not part of the stacks payroll as a developer or employee to be ripped apart like this for fixing it

you are welcome

this is how open source development works, particularly when a project/repo is actively developed by many people. you're invited to participate, or you can die on your hill and your PR will be discarded.

introducing opinionated changes is not something that will be merged.

bitnet-io commented 4 months ago

it's not optionated...

the instructions currently from stacks DO NOT WORK AT ALL AND ARE DANGEROUS WITH RPC

the instructions that I published work 100% and also keeps the user's wallet safe by keeping the rpc allow commands to only work locally

the old instructions are telling people to use importaddress which makes it impossible for stacks-node to properly connect and interface with the bitcoin wallet

https://developer.bitcoin.org/reference/rpc/importaddress.html

"can be watched as if it were in your wallet but cannot be used to spend."

you guys are making it impossible for people basically

i was nice enough to post the correct 100% working instructions that are safe to use so people can mine for stacks and not be miserable or frustrated from trying to use broken instructions that don't work....

wileyj commented 4 months ago

closing as spam

bitnet-io commented 4 months ago

how about instead of closing it as spam

why don't you take my instructions and just fix the document that people are relying on

you are getting paid to work for stacks as an employee

this is a simple thing that takes 10 minutes to properly correct

the facts...

the WIF key must be imported using

importprivkey

after creating a legacy wallet with Bitcoin

or it will not work

the facts...

Config.toml must contain the wallet name from Bitcoin or stacks-node will not properly connect with rpc

[burnchain] wallet_name = "your-bitcoin-wallet-name" 

the facts...

rpcallowip=0.0.0.0/0

is dangerous for unsuspecting users that expose the Bitcoin wallet internally to the WAN side of the Internet

the safest way is to keep rpc restricted only to localhost to listen for commands locally

rpcallowip=127.0.0.1

this protects the user so that the wallet's internal commands can't be accessed by anyone remotely on the Internet since there are constantly robots and scripts that scan IPs on the Internet for open ports with nmap to exploit IPs including ports

22,80,443,8332,9332

bitnet-io commented 4 months ago

closing as spam

that's so nice of you

people are trusting the instructions to work

not to be driven miserable using instructions that are impossible