stacks-network / gaia

A decentralized high-performance storage system

MIT License

762 stars 149 forks source link

Bugfix: Fix github actions by removing slack #403

Closed bjorger closed 2 years ago

bjorger commented 2 years ago

Goal of PR

Please describe exactly what the goal of your PR is (and link to any relevant issues)

Implementation

That the github action executes successfully

Manual Testing

Press "run workflow" in the actions tab

Automated Testing

Triggers on each PR

Submission Checklist

[ ] Based on correct branch: feature submissions should be on develop, hotfixes should be on master
[ ] The code passes our eslint definitions, unit tests, and contains correct TypeFlow annotations.
[ ] Submission contains tests that cover any and all new functionality or code changes.
[ ] Submission documents any new features or endpoints, and describes how developers would be expected to interact with them.
[ ] Author has agreed to our contributor's agreement.

codecov[bot] commented 2 years ago

Codecov Report

Merging #403 (a514942) into master (87b6be4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files          14       14           
  Lines        1474     1474           
  Branches      280      280           
=======================================
  Hits         1117     1117           
  Misses        282      282           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87b6be4...a514942. Read the comment docs.

bjorger commented 2 years ago

Also see github actions execute successfully on my fork, after applying the same changes as proposed in this PR.

https://github.com/bjorger/gaia/actions

criadoperez commented 2 years ago

Thanks @bjorger for this PR. Does this remove the tests that are failing or fixes them?

bjorger commented 2 years ago

@criadoperez this does not remove or fix any tests. The tests were not broken, the thing that was breaking for the action were misconfigured / broken hooks for slack notifications. I removed those.