Open Kefkius opened 9 years ago
Hi @Kefkius thanks for the suggestions and pull request. I have a few questions:
class KefkiusCoinPrivateKey(BitcoinPrivateKey):
_pubkeyhash_version_byte = 42
kefkius_priv_1 = KefkiusCoinPrivateKey()
kefkius_priv_2 = KefkiusCoinPrivateKey()
Here, one can create a new class for a new coin and then create new instances of the class. This is in contrast to your pull request, where you allow users to create new keys without defining a new class.
@rxl You're welcome. I see that the method you described is at least as useful as mine to a user. I made the pull request after seeing that so many coins were on "to-do" implementation status. I figured this would be an easy little hack to use, but yes, the method you described is just as effective, and may be a better option.
As for WIF versions: Yes, I've had to explicitly define a WIF version.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Add two classes, CoinPrivateKey and CoinPublicKey, that take a version byte parameter in their constructors. Also allow WIF version byte to be specified via a parameter.