search

stacks-network / sbtc-bridge-api

GNU Affero General Public License v3.0
6 stars 4 forks source link

Bug: p2tr address calculated differently than romeo #85

Closed friedger closed 12 months ago

friedger commented 12 months ago

Romeo engine uses p2tr function of the bdk crate to get the taproot address from a public key.

The lib uses btc package and encode function. With the p2tr function, the same taproot is created as Romeo engine.

See https://github.com/paulmillr/scure-btc-signer/issues/60

radicleart commented 12 months ago

The bridge method for calculating the p2tr address now aligns with the bdk crate - i think this is correct but lets leave this open today in case Miller comes back with new info?

radicleart commented 12 months ago

Fixed by https://github.com/stacks-network/sbtc-bridge-api/pull/86