stacks-network / sbtc-developer-release

sBTC primitives, signer components, helper tools
https://sbtc.tech
MIT License
1.98k stars 22 forks source link

[sBTC DR] StacksTransactionUpdate event processed too often #328

Open friedger opened 10 months ago

friedger commented 10 months ago

Expected Behavior

Each event should be handled only once

Actual Behavior

2023-10-27T06:24:15.913047Z  INFO update: romeo::state: Processing event=StacksTransactionUpdate(0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b, Broadcasted)
2023-10-27T06:24:15.913121Z DEBUG update: romeo::state: Ignoring Broadcasted status update for a Stacks transaction that is not acknowledged: 0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b event=StacksTransactionUpdate(0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b, Broadcasted)
2023-10-27T06:24:15.913148Z DEBUG update: romeo::state: Ignoring Broadcasted status update for a Stacks transaction that is not acknowledged: 0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b event=StacksTransactionUpdate(0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b, Broadcasted)
2023-10-27T06:24:15.913166Z DEBUG update: romeo::state: Ignoring Broadcasted status update for a Stacks transaction that is not acknowledged: 0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b event=StacksTransactionUpdate(0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b, Broadcasted)
2023-10-27T06:24:15.913184Z DEBUG update: romeo::state: Ignoring Broadcasted status update for a Stacks transaction that is not acknowledged: 0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b event=StacksTransactionUpdate(0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b, Broadcasted)
2023-10-27T06:24:15.913203Z DEBUG update: romeo::state: Ignoring Broadcasted status update for a Stacks transaction that is not acknowledged: 0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b event=StacksTransactionUpdate(0c6d2636b8e5b92a640b6b8fbf59efa7e6e580ea4eb47bd21c09f291059aeb4b, Broadcasted)

Steps to Reproduce

Let romeo run for a few hours and do some deposits and withdrawals

radicleart commented 10 months ago

with the panic removed (#333 ) and after restarting and indexing from the previous contract i see a lot of these lines in the log;

2023-10-28T15:53:03.882353Z DEBUG update: romeo::state: Ignoring Broadcasted status update for a Stacks transaction that is not acknowledged: 0000000000000000000000000000000000000000000000000000000000000000 event=StacksTransactionUpdate(0000000000000000000000000000000000000000000000000000000000000000, Broadcasted)
stjepangolemac commented 10 months ago

Hm, this is definitely a regression as I've never seen this behavior before. I'll look into it.