stacks-network / sbtc-developer-release

sBTC primitives, signer components, helper tools
https://sbtc.tech
MIT License
1.98k stars 23 forks source link

test: Add `Codec` trait unit tests #413

Open ldiego08 opened 10 months ago

ldiego08 commented 10 months ago

Summary of Changes

NOTE: There are some assertions against hex representations of the expected value to keep the tests as readable as possible and to avoid replicating the serialization or deserialization code. Formal snapshot testing using a crate like insta can prove a more scalable alternative asserting between complex values.

Testing

Run tests normally via cargo make test.

Risks

None.

How were these changes tested?

Changes are tests themselves and were verified by running cargo make test.

What future testing should occur?

None.

Checklist:

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

ldiego08 commented 10 months ago

@CAGS295 seems like merging is blocked due to one workflow needing approval. Is there something else I need to do to get this merged?

CAGS295 commented 10 months ago

Hi @ldiego08, thank you for your contribution. You need to wait for a core maintainer to approve the workflow. @AshtonStephens