stacks-network / sbtc-developer-release

sBTC primitives, signer components, helper tools
https://sbtc.tech
MIT License
1.98k stars 23 forks source link

Unified state filter #415

Open CAGS295 opened 10 months ago

CAGS295 commented 10 months ago

Summary of Changes

It should fix #328 and #333. It may also fix #268, but I haven't tested it explicitly.

Testing

Risks

How were these changes tested?

I ran a deposit/withdrawal loop until errors popped. You can find the source code here.

What future testing should occur?

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (6470223) 43.44% compared to head (724aa1a) 47.93%. Report is 4 commits behind head on main.

Files Patch % Lines
romeo/src/system.rs 0.00% 42 Missing :warning:
romeo/src/state/mod.rs 83.25% 35 Missing :warning:
romeo/src/state/transaction_request.rs 87.50% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #415 +/- ## ========================================== + Coverage 43.44% 47.93% +4.48% ========================================== Files 45 46 +1 Lines 5467 5656 +189 Branches 47 47 ========================================== + Hits 2375 2711 +336 + Misses 3091 2944 -147 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/stacks-network/sbtc/pull/415/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stacks-network) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/stacks-network/sbtc/pull/415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stacks-network) | `76.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stacks-network#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.