search

stacks-network / sbtc-developer-release

sBTC primitives, signer components, helper tools
https://sbtc.tech
MIT License
1.98k stars 23 forks source link

[sBTC DR] Should we clean Romeo state when possible #99

Open stjepangolemac opened 1 year ago

stjepangolemac commented 1 year ago

When the deposits and withdrawals are fully processed, and all their transactions confirmed, should we remove them from Romeo state to keep it as small as possible — making it easier to understand it when debugging.

NOTE: Even if they're removed from the working state they'll still be included in the event log.

What do you think? @netrome @AshtonStephens @jferrant @sergey-shandar

netrome commented 1 year ago

Yep, I don't see why we wouldn't prune the running state. Especially since everything is visible from the event log.

stjepangolemac commented 1 year ago

Yeah I agree. The rule could be something like "delete successful sBTC operation data after N confirmation blocks", where N could be 256 or even 32. 🤷‍♂️

stjepangolemac commented 1 year ago

@friedger what do you think about this?

friedger commented 1 year ago

I think it is not the purpose of the signer to maintain a state for others. After work is done, we can forget..

The bridge has an api for the state.